Solace Spring cloud stream and opentracing

Hi @marc
Here some information what happens when I start it without doing anything but adding the dependency to jaeger:
The io.opentracing.contrib.spring.integration.messaging.OpenTracingChannelInterceptor#OpenTracingChannelInterceptor from https://github.com/opentracing-contrib/java-spring-messaging/tree/master/opentracing-spring-messaging enriches the Message with the following headers:

these leads to problems in com.solace.spring.cloud.stream.binder.util.XMLMessageMapper#addSDTMapObject
Because the ThreadLocalScope is not an instance of Serializable..

Here you can find how they do it for rabbitmq:
https://github.com/opentracing-contrib/java-spring-rabbitmq/blob/master/opentracing-spring-rabbitmq/src/main/java/io/opentracing/contrib/spring/rabbitmq/RabbitMqSendTracingAspect.java
https://github.com/opentracing-contrib/java-spring-rabbitmq/blob/master/opentracing-spring-rabbitmq/src/main/java/io/opentracing/contrib/spring/rabbitmq/RabbitMqReceiveTracingInterceptor.java
or for jms:
https://github.com/opentracing-contrib/java-jms/tree/master/opentracing-jms-spring/src/main/java/io/opentracing/contrib/jms/spring

Best regards
Mike

Hi @marc
I have finally found some time and could continue working on this project. I didn't manage to intercept InboundXMLMessageListener.handleMessage because the JCSMPInboundChannelAdapter.buildListener method is private. But I did this:

@Configuration
@EnableConfigurationProperties({SolaceExtendedBindingProperties.class})
@ComponentScan(excludeFilters = {
        @ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, value = {SolaceMessageChannelBinderConfiguration.class})})
public class SolaceMessageChannelBinderTracingConfiguration {

    private static final Logger LOG = LoggerFactory.getLogger(SolaceMessageChannelBinderTracingConfiguration.class);

    private final SpringJCSMPFactory springJCSMPFactory;
    private final SolaceExtendedBindingProperties solaceExtendedBindingProperties;

    private JCSMPSession jcsmpSession;

    public SolaceMessageChannelBinderTracingConfiguration(
            final SpringJCSMPFactory springJCSMPFactory,
            final SolaceExtendedBindingProperties solaceExtendedBindingProperties) {
        this.springJCSMPFactory = springJCSMPFactory;
        this.solaceExtendedBindingProperties = solaceExtendedBindingProperties;
    }

    @PostConstruct
    private void initSession() throws JCSMPException {
        jcsmpSession = springJCSMPFactory.createSession();
        LOG.info(String.format("Connecting JCSMP session %s", jcsmpSession.getSessionName()));
        jcsmpSession.connect();
    }

    @Bean
    SolaceMessageChannelBinder solaceMessageChannelBinder(
            final SolaceOutboundMessageTracingAspect outputMessageTracingAspect,
            final SolaceInboundMessageTracingAspect inboundMessageTracingAspect) {
        final SolaceMessageChannelBinder binder = new SolaceMessageChannelBinder(jcsmpSession, provisioningProvider()) {
            @Override
            protected MessageHandler createProducerMessageHandler(ProducerDestination destination, ExtendedProducerProperties producerProperties,
                    MessageChannel errorChannel) {
                final MessageHandler messageHandler = super.createProducerMessageHandler(destination, producerProperties, errorChannel);
                return ProxyUtil.createProxy(messageHandler, outputMessageTracingAspect);
            }

            @Override
            protected MessageProducer createConsumerEndpoint(ConsumerDestination destination, String group, ExtendedConsumerProperties properties) {
                final MessageProducer messageProducer = super.createConsumerEndpoint(destination, group, properties);
                return ProxyUtil.createProxy(messageProducer, inboundMessageTracingAspect);
            }
        };
        binder.setExtendedBindingProperties(solaceExtendedBindingProperties);
        return binder;
    }

    @Bean
    SolaceQueueProvisioner provisioningProvider() {
        return new SolaceQueueProvisioner(jcsmpSession);
    }
}

With the outboundMessageTracingAspect I intercept_ org.springframework.messaging.MessageHandler.handleMessage_ to decorate the message with tracing information.
With the inboundMessageTracingAspect I intercept org.springframework.integration.core.MessageProducer.setOutputChannel to adapt the MessageChannel. The adapter extracts the tracing information out of the message before delegating to the real messageChannel.
But now I have to dive into the opentracing topic to get the tracing implementation right.

Hi @marc
I just put the code on github.
The project https://github.com/MikeR13/esta-spring-cloud-stream-solace contains an example app for spring cloud stream with solace and I also put the code for the opentracing "project" there (https://github.com/MikeR13/esta-spring-cloud-stream-solace/tree/master/src/main/java/io/opentracing/contrib downwards). But please do not look too closely, it is a draft ;-)
Regarding the "non-serializable header issue":
There is still an open question on stackoverflow that I have asked https://stackoverflow.com/questions/63491625/opentracing-spring-cloud-stream-and-solace .

Hi @marc
I was on vacation, so I didn't do much more on the subject. The only thing I found out is that this approach does not work if I define another binder in addition to the Solace binder. I hope to be able to continue here soon....