Spring cloud stream Solace binder prevents application from running when Solace is down

Hi @marc thanks for your prompt reply, when the application is running there is no problem and it starts trying to reconnect to the broker while it is serving the HTTP clients, the problem is when you want to run a new instance or restart an instance while the broker is down then the application starts retrying and doesn't allow the HTTP server serve the clients until the connection is completed or the retry counts reach the limit (when the retry count is reached the application exits)

@Aaron your understanding is correct the application has a DB and it connects to Solace through SCS for updating and populating the DB, and at the same time it provides some HTTP endpoints for its users to read and see those data from the DB, the problem is SCS bean should be created successfully in the bean creation chain and apparently embedded application server bean is built after that and prevents the application from running, in our use-case it is crucial to start the application independently even when the broker is out of reach.

org.springframework.context.ApplicationContextException: Failed to start bean 'inputBindingLifecycle'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'com.solace.spring.cloud.stream.binder.config.SolaceMessageChannelBinderConfiguration': Invocation of init method failed; nested exception is com.solacesystems.jcsmp.InvalidPropertiesException: All hosts in the host list: 'tcps://example:55443' are not resolvable
	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:181) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356) ~[spring-context-5.3.22.jar:5.3.22]
	at java.base/java.lang.Iterable.forEach(Iterable.java:75) ~[na:na]
	at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:935) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:586) ~[spring-context-5.3.22.jar:5.3.22]
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147) ~[spring-boot-2.7.3.jar:2.7.3]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:734) ~[spring-boot-2.7.3.jar:2.7.3]
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408) ~[spring-boot-2.7.3.jar:2.7.3]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:308) ~[spring-boot-2.7.3.jar:2.7.3]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1306) ~[spring-boot-2.7.3.jar:2.7.3]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1295) ~[spring-boot-2.7.3.jar:2.7.3]
	at com.ingka.solacescs.SolacescsApplicationKt.main(SolacescsApplication.kt:13) ~[main/:na]
Caused by: com.solacesystems.jcsmp.InvalidPropertiesException: All hosts in the host list: 'tcps://example:55443' are not resolvable
	at com.solacesystems.jcsmp.JCSMPFactory.validate(JCSMPFactory.java:410) ~[sol-jcsmp-10.16.0.jar:na]
	at com.solacesystems.jcsmp.JCSMPFactory.createSession(JCSMPFactory.java:164) ~[sol-jcsmp-10.16.0.jar:na]
	at com.solacesystems.jcsmp.JCSMPFactory.createSession(JCSMPFactory.java:122) ~[sol-jcsmp-10.16.0.jar:na]
	at com.solace.spring.cloud.stream.binder.config.SolaceMessageChannelBinderConfiguration.initSession(SolaceMessageChannelBinderConfiguration.java:57) ~[spring-cloud-stream-binder-solace-3.4.0.jar:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[na:na]
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
	at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[na:na]
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleElement.invoke(InitDestroyAnnotationBeanPostProcessor.java:389) ~[spring-beans-5.3.22.jar:5.3.22]
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor$LifecycleMetadata.invokeInitMethods(InitDestroyAnnotationBeanPostProcessor.java:333) ~[spring-beans-5.3.22.jar:5.3.22]
	at org.springframework.beans.factory.annotation.InitDestroyAnnotationBeanPostProcessor.postProcessBeforeInitialization(InitDestroyAnnotationBeanPostProcessor.java:157) ~[spring-beans-5.3.22.jar:5.3.22]
	... 37 common frames omitted


5 actionable tasks: 3 executed, 2 up-to-date


FAILURE: Build failed with an exception.

Also, I tried to extend the related bean and change the behavior but there is a problem with the second constructor parameter, the error says the second parameter cannot be autowired but I can see the SCS solace binder producing bean (I think the problem is about bean creation order)

import com.solace.spring.cloud.stream.binder.SolaceMessageChannelBinder
import com.solace.spring.cloud.stream.binder.config.SolaceBinderHealthIndicatorConfiguration
import com.solace.spring.cloud.stream.binder.config.SolaceMessageChannelBinderConfiguration
import com.solace.spring.cloud.stream.binder.meter.SolaceMeterAccessor
import com.solace.spring.cloud.stream.binder.properties.SolaceExtendedBindingProperties
import com.solace.spring.cloud.stream.binder.provisioning.SolaceQueueProvisioner
import com.solace.spring.cloud.stream.binder.util.SolaceSessionEventHandler
import com.solacesystems.jcsmp.*
import com.solacesystems.jcsmp.impl.client.ClientInfoProvider
import org.springframework.boot.context.properties.EnableConfigurationProperties
import org.springframework.context.annotation.*
import org.springframework.lang.Nullable
import java.util.concurrent.CompletableFuture
import javax.annotation.PostConstruct

@Primary
@Configuration
@Import(SolaceBinderHealthIndicatorConfiguration::class)
@EnableConfigurationProperties(SolaceExtendedBindingProperties::class)
@Lazy
class SolaceMessageChannelBinderConfiguration(
    private val jcsmpProperties: JCSMPProperties,
    private val solaceExtendedBindingProperties: SolaceExtendedBindingProperties,
    private val solaceSessionEventHandler: SolaceSessionEventHandler,
) : SolaceMessageChannelBinderConfiguration(
    jcsmpProperties,
    solaceExtendedBindingProperties,
    solaceSessionEventHandler,
) {
    private var jcsmpSession: JCSMPSession? = null
    private var context: Context? = null

    @PostConstruct
    private fun initSession() {
        CompletableFuture.runAsync {
            val jcsmpProperties = jcsmpProperties.clone() as JCSMPProperties
            jcsmpProperties.setProperty(JCSMPProperties.CLIENT_INFO_PROVIDER, SolaceBinderClientInfoProvider())
            try {
                if (solaceSessionEventHandler != null) {
                    context = JCSMPFactory.onlyInstance().createContext(ContextProperties())
                    jcsmpSession =
                        JCSMPFactory.onlyInstance().createSession(jcsmpProperties, context, solaceSessionEventHandler)
                } else {
                    jcsmpSession = JCSMPFactory.onlyInstance().createSession(jcsmpProperties)
                }
                jcsmpSession!!.connect()
                solaceSessionEventHandler?.connected()
            } catch (e: Exception) {
                if (context != null) {
                    context!!.destroy()
                }
                throw e
            }
        }
    }

    @Bean
    fun solaceMessageChannelBinder(
        solaceQueueProvisioner: SolaceQueueProvisioner?,
        @Nullable solaceMeterAccessor: SolaceMeterAccessor?,
    ): SolaceMessageChannelBinder? {
        val binder = SolaceMessageChannelBinder(jcsmpSession, context, solaceQueueProvisioner)
        binder.setExtendedBindingProperties(solaceExtendedBindingProperties)
        binder.setSolaceMeterAccessor(solaceMeterAccessor)
        return binder
    }

    @Bean
    fun provisioningProvider(): SolaceQueueProvisioner? {
        return SolaceQueueProvisioner(jcsmpSession)
    }
}

internal class SolaceBinderClientInfoProvider : ClientInfoProvider() {
    override fun getSoftwareVersion(): String {
        return String.format("3.4.0 (%s)", super.getSoftwareVersion())
    }

    override fun getSoftwareDate(): String {
        return String.format("2022-10-20 19:33:36 (%s)", super.getSoftwareDate())
    }

    override fun getPlatform(): String {
        return this.getPlatform("Solace Spring Cloud Stream Binder (JCSMP SDK)")
    }
}

Error:

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2023-05-01 10:14:20.291 ERROR 57632 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   : 


***************************
APPLICATION FAILED TO START
***************************


Description:


Parameter 2 of constructor in com.ingka.solacescs.SolaceMessageChannelBinderConfiguration required a bean of type 'com.solace.spring.cloud.stream.binder.util.SolaceSessionEventHandler' that could not be found.




Action:


Consider defining a bean of type 'com.solace.spring.cloud.stream.binder.util.SolaceSessionEventHandler' in your configuration.